UI: Fix oidc auth method missing default_role field #28539
UI: Fix oidc auth method missing default_role field #28539hellobontempo merged 7 commits intomainfrom
Conversation
github-actions
bot
added
the
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
| {{on "change" this.onChange}} | ||
| {{on "keyup" (fn this.handleKeyUp @name)}} | ||
| data-test-textarea={{or @name ""}} | ||
| data-test-input={{or @name ""}} |
There was a problem hiding this comment.
There was a lot of logic in tests because this selector differed from the standard pattern, updated it and relevant selectors to make future tests easier to write
There was a problem hiding this comment.
I've also run into this. Thank you!
| // These models use openAPI so we assert the form inputs using an acceptance test | ||
| // The default selector is to use GENERAL.inputByAttr() | ||
| // custom fields should be added to the this.customSelectorss object | ||
| module('Acceptance | auth enable tune form test', function (hooks) { |
There was a problem hiding this comment.
I only added tests for azure, jwt, oidc, okta and ldap for now. We can expand as needed
|
✅ enterprise tests |
Monkeychip
left a comment
Monkeychip
left a comment
There was a problem hiding this comment.
Nice work. Reminder to run ent tests if you haven't already.
Yep - mentioned that in my previous comment here: Would you prefer I mention it in the description next time? |
| * This object maps model names to the openAPI path that hydrates the model, given the backend path. | ||
| */ | ||
| const OPENAPI_POWERED_MODELS = { | ||
| 'role-ssh': (backend: string) => `/v1/${backend}/roles/example?help=1`, |
| 'auth-config/jwt': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/kubernetes': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/ldap': (backend: string) => `/v1/auth/${backend}/config?help=1`, | ||
| 'auth-config/oidc': (backend: string) => `/v1/auth/${backend}/config?help=1`, |
There was a problem hiding this comment.
this is the only new one!
2 participants
Description
Fixes
default_rolemissing from OIDC form. The field was accidentally removed when #27764 was implemented becauseauth-config/oidcwas left out of the helper const. This happened because the model inherits fromjwtmaking it easy to miss during the refactor. I added some test coverage for some of these open api models so it doesn't happen againbefore
after
TODO only if you're a HashiCorp employee
to N, N-1, and N-2, using the
backport/ent/x.x.x+entlabels. If this PR is in the CE repo, you should only backport to N, using thebackport/x.x.xlabel, not the enterprise labels.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.